From reviews-return-92110-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 4 04:26:06 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 6917219C22 for ; Tue, 4 Aug 2020 04:26:06 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1A544124337 for ; Tue, 4 Aug 2020 04:26:06 +0000 (UTC) Received: (qmail 31702 invoked by uid 500); 4 Aug 2020 04:26:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31687 invoked by uid 500); 4 Aug 2020 04:26:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31669 invoked by uid 99); 4 Aug 2020 04:26:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2020 04:26:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 92DD8C0B1A for ; Tue, 4 Aug 2020 04:26:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.862 X-Spam-Level: * X-Spam-Status: No, score=1.862 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XxeFsSNJbPQn for ; Tue, 4 Aug 2020 04:26:02 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 7C422BE7E9 for ; Tue, 4 Aug 2020 04:26:02 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id B322016025E; Tue, 4 Aug 2020 04:26:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3610007175403326761==" MIME-Version: 1.0 Subject: Re: Review Request 72709: Fixed the tests warning messages. From: Dong Zhu To: Benjamin Mahler Cc: Mesos Reviewbot , Dong Zhu , mesos Date: Tue, 04 Aug 2020 04:26:01 -0000 Message-ID: <20200804042601.14498.13748@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dong Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72709/ X-Sender: Dong Zhu References: <20200727171248.20915.64175@reviews-vm-he-fi.apache.org> In-Reply-To: <20200727171248.20915.64175@reviews-vm-he-fi.apache.org> Reply-To: Dong Zhu X-ReviewRequest-Repository: mesos --===============3610007175403326761== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote: > > Hm.. it seems this was done to support running the tests from an installation? > > > > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1 > > Dong Zhu wrote: > Yes. But this issue exists even from an installation without this fix unless specified option `--build_dir=/none` explicitly: > > ``` > $PREFIX/libexec/mesos/tests/mesos-tests/mesos-tests --gtest_filter="ContainerizerTest.ROOT_CGROUPS_BalloonFramework" --verbose > /root/mesos-development/mesos/src/tests/balloon_framework_test.sh: line 8: /root/mesos-development/mesos/build/src/colors.sh: No such file or directory > /root/mesos-development/mesos/src/tests/balloon_framework_test.sh: line 9: /root/mesos-development/mesos/build/src/atexit.sh: No such file or directory > ``` > > If user leave the `--source_dir=/nowhere` options as default or specify an valid path this patch works with the both circumstances. > If use specify both `--source_dir=/nowhere` **(invalid path)** and `--build_dir=/none` explicitly, there will be following error show up: > > ``` > /usr/local/mesos-develop/libexec/mesos/tests/balloon_framework_test.sh: line 6: /nowhere/support/colors.sh: No such file or directory > /usr/local/mesos-develop/libexec/mesos/tests/balloon_framework_test.sh: line 7: /nowhere/support/atexit.sh: No such file or directory > ``` > > I suppose it is confusing users therefore it is necessary to fix it and there are two methods here: > 1. use the original commit I submitted > 2. add checks for the source `${MESOS_SOURCE_DIR}/support/colors.sh` to prevent the `No such file or directory` showing up: > ``` > FILE="${MESOS_SOURCE_DIR}/support/colors.sh" && test -f $FILE && source $FILE > FILE="${MESOS_SOURCE_DIR}/support/atexit.sh" && test -f $FILE && source $FILE > FILE="${MESOS_HELPER_DIR}/colors.sh" && test -f $FILE && source $FILE > FILE="${MESOS_HELPER_DIR}/atexit.sh" && test -f $FILE && source $FILE > ``` > > What's your opinon here and which method will you prefer ? > > Dong Zhu wrote: > Hi Ben, any comments here ? > > Benjamin Mahler wrote: > Hm.. I suppose option 2 with an explanation of why we check both locations would be ok. I have updated the patch, please review it again, thanks ! - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72709/#review221383 ----------------------------------------------------------- On Aug. 4, 2020, 12:24 p.m., Dong Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72709/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2020, 12:24 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Remove unnecessary codes which lead to the following warnning > messages while performing tests: > > ...mesos/build/src/colors.sh: No such file or directory > ...mesos/build/src/atexit.sh: No such file or directory > > > Diffs > ----- > > src/tests/balloon_framework_test.sh 7d0a4fee200577a5f7b2edbb3b310a07678879dd > src/tests/disk_full_framework_test.sh 62e62cb90ffb5c05f0db1517409179d5b38518e8 > src/tests/dynamic_reservation_framework_test.sh c094ed1464c61b6acf647549f1fd83117b135358 > src/tests/no_executor_framework_test.sh df282cab6e91645d19d0aa09867e6b45adaf2508 > src/tests/persistent_volume_framework_test.sh 6488656c4bd8ad0c6f25a367cf7de2f926dbecf0 > src/tests/test_framework_test.sh 8782e01edc5be3833760fc45e2b545fce100547b > src/tests/test_http_framework_test.sh 256655dfd7697071547f755e8941822b6d51f8a8 > > > Diff: https://reviews.apache.org/r/72709/diff/2/ > > > Testing > ------- > > make tests > > > Thanks, > > Dong Zhu > > --===============3610007175403326761==--