From reviews-return-92103-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 3 21:28:45 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id C9A2B19F72 for ; Mon, 3 Aug 2020 21:28:45 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 6953B1248C7 for ; Mon, 3 Aug 2020 21:28:44 +0000 (UTC) Received: (qmail 25530 invoked by uid 500); 3 Aug 2020 21:28:44 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 25509 invoked by uid 500); 3 Aug 2020 21:28:44 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 25491 invoked by uid 99); 3 Aug 2020 21:28:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2020 21:28:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ED69EC00C3 for ; Mon, 3 Aug 2020 21:28:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.611 X-Spam-Level: * X-Spam-Status: No, score=1.611 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JfFh46cVK8fX for ; Mon, 3 Aug 2020 21:28:40 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 5B1B3BE876 for ; Mon, 3 Aug 2020 21:28:40 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id DD16816025E; Mon, 3 Aug 2020 21:28:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0013942262385459008==" MIME-Version: 1.0 Subject: Re: Review Request 72728: Added a unit test for the CSI server. From: Mesos Reviewbot To: Qian Zhang , Andrei Budnik Cc: Mesos Reviewbot , Greg Mann , mesos Date: Mon, 03 Aug 2020 21:28:38 -0000 Message-ID: <20200803212838.14498.29750@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72728/ X-Sender: Mesos Reviewbot References: <20200731190932.21172.33000@reviews-vm-he-fi.apache.org> In-Reply-To: <20200731190932.21172.33000@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/csi_server_tests.cpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0013942262385459008== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221454 ----------------------------------------------------------- Patch looks great! Reviews applied: [72660, 72661, 72672, 72681, 72715, 72707, 72716, 72726, 72727, 72728] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On July 31, 2020, 7:09 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72728/ > ----------------------------------------------------------- > > (Updated July 31, 2020, 7:09 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that > the CSI server can load a plugin and execute publish and > unpublish calls against it. > > > Diffs > ----- > > src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 > src/tests/csi_server_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72728/diff/1/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Greg Mann > > --===============0013942262385459008==--