mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Date Mon, 31 Aug 2020 21:14:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72824/#review221760
-----------------------------------------------------------



Can you comment on the PID aspect of the change in the description and code comment?

E.g. for agent message we don't care about the PID changing since it was way back in 0.25,
etc.. but maybe let's just remove that PID code in `sendFrameworkUpdates` at this point..?


src/master/master.cpp
Line 3291 (original), 3300-3302 (patched)
<https://reviews.apache.org/r/72824/#comment310816>

    Now that it's become conditional, do we want to log whether we're broadcasting the framework
update?



src/master/master.cpp
Line 3291 (original), 3301 (patched)
<https://reviews.apache.org/r/72824/#comment310817>

    The PID could have changed, we can probably just remove that PID code within `sendFrameworkUpdates`
at this point.
    
    With the PID code still there, one can see that this if condition is not capturing the
potential PID change we'd want to tell the agent about.


- Benjamin Mahler


On Aug. 31, 2020, 6:05 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72824/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2020, 6:05 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10166
>     https://issues.apache.org/jira/browse/MESOS-10166
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the UPDATE_FRAMEWORK call avoid sending the
> `UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED`
> event to V1 API subscribers when the FrameworkInfo is not changed
> by the call.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e 
> 
> 
> Diff: https://reviews.apache.org/r/72824/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message