mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Date Mon, 31 Aug 2020 18:03:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72822/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10166
    https://issues.apache.org/jira/browse/MESOS-10166


Repository: mesos


Description
-------

This patch extracts the code that performs `FrameworkInfo` comparison
via protobuf `MessageDifferencer` from the framework update tests
into a set of general-purpose methods.


Diffs
-----

  src/common/protobuf_utils.hpp 0558249023b39863b4030ddbcfe5c83dc945570a 
  src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0 
  src/tests/master/update_framework_tests.cpp 6346a4eaf2b6c70d1a7d5f32706e781436d36521 


Diff: https://reviews.apache.org/r/72822/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message