mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Date Wed, 26 Aug 2020 18:12:03 GMT


> On Aug. 26, 2020, 7:54 a.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 19 (patched)
> > <https://reviews.apache.org/r/72728/diff/10/?file=2238776#file2238776line19>
> >
> >     Do we need this?

Whoops, you commented on this before. I removed it but I still had the change stashed locally,
I'm sorry!


> On Aug. 26, 2020, 7:54 a.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 278-282 (patched)
> > <https://reviews.apache.org/r/72728/diff/10/?file=2238776#file2238776line278>
> >
> >     Can we just do `Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(),
agentFlags);` instead?

`SlaveOptions` provides a more easily-maintained interface and is now the preferred way to
start agents in our tests: https://github.com/apache/mesos/blob/62931a04f2cd2a1951d04bd348ff23700cc73d9b/src/tests/mesos.hpp#L258-L262


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221714
-----------------------------------------------------------


On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2020, 5:57 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the 'volume/csi' isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 
>   src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/10/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message