mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Date Wed, 26 Aug 2020 07:54:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221714
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/CMakeLists.txt
Lines 236 (patched)
<https://reviews.apache.org/r/72728/#comment310766>

    I think this line should be moved to line 215 below. Ditto for the `src/Makefile.am` below.



src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 19 (patched)
<https://reviews.apache.org/r/72728/#comment310767>

    Do we need this?



src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 254 (patched)
<https://reviews.apache.org/r/72728/#comment310768>

    Can we add a description for this test?



src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/72728/#comment310769>

    Kill this newline.



src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 278-282 (patched)
<https://reviews.apache.org/r/72728/#comment310770>

    Can we just do `Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(),
agentFlags);` instead?



src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 541 (patched)
<https://reviews.apache.org/r/72728/#comment310771>

    Do we want to unpublish the volume at the end of this test? Otherwise there will be a
mount left on the host filesystem?


- Qian Zhang


On Aug. 26, 2020, 1:57 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2020, 1:57 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the 'volume/csi' isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 
>   src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/10/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message