mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Date Wed, 26 Aug 2020 05:57:53 GMT


> On Aug. 25, 2020, 2:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> >     It seems we only want to verify the behavior of CSI server but not launch a
task from end to end, maybe we do not need to start master and agent just like what we do
in `ROOT_InvalidPluginConfig`?

In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.

Another option for this test would be to use a task launch to test this same thing from end-to-end.
I left it as-is because the task launching boilerplate makes the test much larger, so this
version is more concise. WDYT?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------


On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2020, 5:57 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the 'volume/csi' isolator.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 
>   src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/10/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message