mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Date Tue, 25 Aug 2020 18:38:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------

(Updated Aug. 25, 2020, 6:38 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Extended the comment on RE2 limits


Bugs: MESOS-10173
    https://issues.apache.org/jira/browse/MESOS-10173


Repository: mesos


Description
-------

This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.

Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.

Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.proto 06d62f5f4ed9286a6ad50f80d1261e4e732d1bc7 
  include/mesos/v1/scheduler/scheduler.proto 08fb10a146e0b57896a0cb098178a40e618df392 


Diff: https://reviews.apache.org/r/72784/diff/4/

Changes: https://reviews.apache.org/r/72784/diff/3-4/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message