mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72728: Added unit tests for the CSI server.
Date Tue, 25 Aug 2020 14:41:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------




src/tests/csi_server_tests.cpp
Lines 19 (patched)
<https://reviews.apache.org/r/72728/#comment310753>

    It seems we do not need this?



src/tests/csi_server_tests.cpp
Lines 106-107 (patched)
<https://reviews.apache.org/r/72728/#comment310754>

    A newline between. Ditto for line 111-112.



src/tests/csi_server_tests.cpp
Lines 403 (patched)
<https://reviews.apache.org/r/72728/#comment310758>

    I do not see how this volume is used by the task, I think we should set the volume into
the task's `containerInfo.volumes`.



src/tests/csi_server_tests.cpp
Lines 408 (patched)
<https://reviews.apache.org/r/72728/#comment310757>

    Can we launch the task to run a command to write to the volume rather than just `exit
0`?



src/tests/csi_server_tests.cpp
Lines 457 (patched)
<https://reviews.apache.org/r/72728/#comment310759>

    It seems we only want to verify the behavior of CSI server but not launch a task from
end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?


- Qian Zhang


On Aug. 25, 2020, 5:20 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2020, 5:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests for the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/tests/csi_server_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/9/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message