mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.
Date Tue, 25 Aug 2020 14:11:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72785/#review221706
-----------------------------------------------------------



Bad patch!

Reviews applied: [72785]

Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72785

Error:
2020-08-25 14:11:32 URL:https://reviews.apache.org/r/72785/diff/raw/ [7759/7759] -> "72785.patch"
[1]

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <jenkins@asf931.gq1.ygridcore.net>) not allowed

Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/102/console

- Mesos Reviewbot


On Aug. 17, 2020, 8:20 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72785/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2020, 8:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
>     https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a key-value cache that hands out shared pointers to
> cached items, but does not own the items (hence, the items get
> deleted as soon as they are no longer referenced by anything else).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am ad3f2105d9e159995be1979007d6ddbe5ec9e133 
>   3rdparty/stout/include/stout/weak_cache.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt e3291c72d1875f5b196dd5ea2ba20e7d53881b87 
>   3rdparty/stout/tests/weak_cache_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72785/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message