mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72786: Implemented regex-based offer constraints.
Date Mon, 24 Aug 2020 21:30:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/#review221697
-----------------------------------------------------------



Hm.. is it possible to have a simpler patch that avoids the factory and instead passes the
flags through the creation path?


src/master/allocator/mesos/offer_constraints_filter.cpp
Lines 113-119 (patched)
<https://reviews.apache.org/r/72786/#comment310750>

    How did you figure this out? Just from your own testing?
    
    What about with clang? Same result?
    
    How much faster? Is it worth bothering?



src/master/allocator/mesos/offer_constraints_filter.cpp
Lines 230 (patched)
<https://reviews.apache.org/r/72786/#comment310749>

    Seems more readable to format this and the one below the same? (i.e. either both on two
lines or both on one?)



src/master/constants.hpp
Lines 182 (patched)
<https://reviews.apache.org/r/72786/#comment310751>

    regular
    
    Anything you can add about how these numbers were produced? Would be helpful.



src/master/flags.hpp
Lines 125-126 (patched)
<https://reviews.apache.org/r/72786/#comment310752>

    Just noticed that these don't line up with the above constant types, is that intentional?
    
    Can we make max_mem of type `Bytes`? That would let a user specify "4kb", "4MB" etc


- Benjamin Mahler


On Aug. 24, 2020, 7:46 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72786/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2020, 7:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10173
>     https://issues.apache.org/jira/browse/MESOS-10173
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented regex-based offer constraints.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 05d0e9c46485c3048a65d46747d56e715883a0b3 
>   src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b 
>   src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION 
>   src/master/allocator/mesos/offer_constraints_filter.cpp ef8a948260d92a9d54efb65f0e5c8aa3d0c67b91

>   src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b 
>   src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 
>   src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a 
>   src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 
>   src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e 
>   src/tests/master/offer_constraints_filter_tests.cpp f88e2011bc510323344ffe58fd550b7683242950

> 
> 
> Diff: https://reviews.apache.org/r/72786/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message