mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72775: Implemented offer constraints on a string attribute equality.
Date Mon, 24 Aug 2020 20:45:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72775/#review221693
-----------------------------------------------------------


Ship it!




Very clean patch!

- Benjamin Mahler


On Aug. 24, 2020, 7:34 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72775/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2020, 7:34 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10172
>     https://issues.apache.org/jira/browse/MESOS-10172
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented offer constraints on a string attribute equality.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/offer_constraints_filter.cpp ef8a948260d92a9d54efb65f0e5c8aa3d0c67b91

> 
> 
> Diff: https://reviews.apache.org/r/72775/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message