-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72784/
-----------------------------------------------------------
(Updated Aug. 24, 2020, 7:37 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Renamed predicates and extended the comment.
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular
expression.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.
Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 9e89c82a7410a6f1d8f62ffff5366673c0fba541
include/mesos/v1/scheduler/scheduler.proto cd5a980aff7eb820a11c7887e605e50b73425239
Diff: https://reviews.apache.org/r/72784/diff/3/
Changes: https://reviews.apache.org/r/72784/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko
|