mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Date Mon, 24 Aug 2020 19:29:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72745/
-----------------------------------------------------------

(Updated Aug. 24, 2020, 7:29 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Renamed into TextEquals/TextNotEquals; extended the comment


Bugs: MESOS-10172
    https://issues.apache.org/jira/browse/MESOS-10172


Repository: mesos


Description
-------

This patch adds protobuf messages for setting offer constraints
on equality/non-equality of agent's (pseudo)attribute to a specified
string.

Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will still perform all
filtration based on non-TEXT attributes on their own, which helps to
avoid subtle integration bugs caused by discrepancies in Scalar/Ranges
comparison between Mesos and the scheduler.

Given that schedulers seem to rarely put constraints on Scalar/Ranges
attributes in the real world, this should not prevent them from
obtaining performance benefits by setting offer constraints.


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.proto 9e89c82a7410a6f1d8f62ffff5366673c0fba541 
  include/mesos/v1/scheduler/scheduler.proto cd5a980aff7eb820a11c7887e605e50b73425239 


Diff: https://reviews.apache.org/r/72745/diff/5/

Changes: https://reviews.apache.org/r/72745/diff/4-5/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message