-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/#review221687
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Line 200 (original), 200 (patched)
<https://reviews.apache.org/r/72789/#comment310741>
Could I suggest a change to the commit message? Perhaps "Refactored state recovery in
volume/csi isolator."? You could mention the part about using the templated protobuf helper
function in the description if you want maybe?
- Greg Mann
On Aug. 23, 2020, 2:33 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72789/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2020, 2:33 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10153
> https://issues.apache.org/jira/browse/MESOS-10153
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Read the checkpointed CSI volume state directly in protobuf message way.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
>
>
> Diff: https://reviews.apache.org/r/72789/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
|