mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Date Sun, 23 Aug 2020 14:32:47 GMT


> On Aug. 22, 2020, 12:28 a.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
> > Line 201 (original), 201 (patched)
> > <https://reviews.apache.org/r/72789/diff/1/?file=2238534#file2238534line201>
> >
> >     Can we do `state::read<CSIVolumes>(volumesPath)` here so that we don't
need to do any extra JSON/protobuf parsing? Then I think this change may not be necessary?

Yes, you are right!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/#review221678
-----------------------------------------------------------


On Aug. 23, 2020, 10:32 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72789/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2020, 10:32 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10153
>     https://issues.apache.org/jira/browse/MESOS-10153
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Read the checkpointed CSI volume state directly in protobuf message way.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8

> 
> 
> Diff: https://reviews.apache.org/r/72789/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message