mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72794: Added a test for discarding image pull on discard of getting image.
Date Fri, 21 Aug 2020 00:58:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72794/#review221669
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72790, 72791, 72792, 72793, 72794]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Aug. 20, 2020, 5:08 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72794/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2020, 5:08 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10169
>     https://issues.apache.org/jira/browse/MESOS-10169
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test checks that when all futures returned by docker store's
> `get()` that are pending image pull are discarded by the callers,
> the pull future (returned by the puller to the store) is discarded
> by the store as well.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc

> 
> 
> Diff: https://reviews.apache.org/r/72794/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message