mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 72790: Deduplicated concurrent image pulls by docker store.
Date Thu, 20 Aug 2020 17:06:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72790/
-----------------------------------------------------------

Review request for mesos and Qian Zhang.


Bugs: MESOS-10169
    https://issues.apache.org/jira/browse/MESOS-10169


Repository: mesos


Description
-------

This patch makes the docker store reuse a pending pull if asked for
an image that is already being pulled.

The pull caching follows the same approach as the earlier attempt in
https://reviews.apache.org/r/39331 . However, handing out futures to
the store callers and handling their discards are performed differently,
using a form of reference counting, so that the pull itself is discarded
only if all the futures returned by `Store::get()` have been discarded.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/store.cpp bf2be90aa4fcd7541849a157eb6930b491ccf03a



Diff: https://reviews.apache.org/r/72790/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message