mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <>
Subject Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Date Thu, 20 Aug 2020 15:16:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 20, 2020, 3:16 p.m.)

Review request for mesos and Benjamin Mahler.


Extended the comment to explain the purpose of non-TEXT pass-through.

Bugs: MESOS-10173

Repository: mesos


This patch adds protobuf messages for setting offer constraints
that check if agent's (pseudo)attribute matches a specified RE2 regular

Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will have to apply on their
own whatever filtration they do for non-TEXT attributes which happen
to be selected by the constraint's `Selector`.

Given that in the real world schedulers seem to rarely put constraints
on attributes that are normally Scalar/Ranges, this should not prevent
them from obtaining performance benefits by setting offer constraints.

Diffs (updated)

  include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc 
  include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3 





Andrei Sekretenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message