mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Thu, 20 Aug 2020 06:41:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221655
-----------------------------------------------------------




src/slave/csi_server.cpp
Line 169 (original), 219 (patched)
<https://reviews.apache.org/r/72779/#comment310724>

    I'd suggest to rename this `name` local var to something like `_name` since we already
have a `name` parameter in this method.
    
    And when the `name` parameter is specified, I think we should only initialize the plugin
of that name rather than initializing all the loaded plugins, right? Otherwise a plugin may
be intialized multiple times in the runtime.



src/slave/csi_server.cpp
Lines 280-282 (patched)
<https://reviews.apache.org/r/72779/#comment310723>

    I think we should log an error message here, otherwise when `initializePlugin()` is called
in `start()` we will not know which plugin is failed to initialize.


- Qian Zhang


On Aug. 20, 2020, 3:04 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2020, 3:04 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initialized plugins lazily in the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 
>   src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message