mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Thu, 20 Aug 2020 02:19:08 GMT


> On Aug. 19, 2020, 3:43 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Line 136 (original), 155 (patched)
> > <https://reviews.apache.org/r/72779/diff/2/?file=2238466#file2238466line158>
> >
> >     If `name` is specified, do we need to do this `os::ls`? I think we can just
load and initialize the specified plugin directly without traversing the entries in `pluginConfigDir`,
right?
> 
> Greg Mann wrote:
>     Are we going to introduce a convention for the naming of the files in that directory?
If not, how will we load the correct file on the first try?

Ah, you are right, we have to do the `os::ls` here.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221636
-----------------------------------------------------------


On Aug. 20, 2020, 3:04 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2020, 3:04 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initialized plugins lazily in the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 
>   src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message