mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72782: Added RE2 to the CMake build.
Date Wed, 19 Aug 2020 18:02:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72782/
-----------------------------------------------------------

(Updated Aug. 19, 2020, 6:02 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Replaced ifdef(WIN32) with a (potentially broken) Windows build.


Bugs: MESOS-10170
    https://issues.apache.org/jira/browse/MESOS-10170


Repository: mesos


Description
-------

This is a prerequisite for implementing regex-based offer constraints.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt af9a071a465dbd57b44f67949d5ec630a1a57a2e 
  3rdparty/cmake/Versions.cmake 93766161da14eab30f4ebf382303073aa2b6d448 
  3rdparty/re2-2020-07-06.tar.gz PRE-CREATION 
  LICENSE 2c5919d1e9b7d1377ad5982c66cef0c962308cf4 
  src/CMakeLists.txt a976dc12328f42d2268b4b5d86a934bf0c754594 


Diff: https://reviews.apache.org/r/72782/diff/2/

Changes: https://reviews.apache.org/r/72782/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message