mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Wed, 19 Aug 2020 18:01:12 GMT


> On Aug. 19, 2020, 7:43 a.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Line 136 (original), 155 (patched)
> > <https://reviews.apache.org/r/72779/diff/2/?file=2238466#file2238466line158>
> >
> >     If `name` is specified, do we need to do this `os::ls`? I think we can just
load and initialize the specified plugin directly without traversing the entries in `pluginConfigDir`,
right?

Are we going to introduce a convention for the naming of the files in that directory? If not,
how will we load the correct file on the first try?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221636
-----------------------------------------------------------


On Aug. 19, 2020, 6:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2020, 6:23 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the CSI server to attempt to
> initialize unknown plugins when it receives publish
> or unpublish calls meant for plugins that it does
> not recognize.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 
>   src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message