mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Wed, 19 Aug 2020 06:25:26 GMT


> On Aug. 17, 2020, 7:15 a.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Line 225 (original), 212 (patched)
> > <https://reviews.apache.org/r/72779/diff/1/?file=2238169#file2238169line243>
> >
> >     What if this method fails somewhere and returns a `Failure`? As the result `CSIServer::started.future()`
will be a failed future and then all the `CSIServer::publishVolume` and `CSIServer::unpublishVolume`
calls will just fail in the runtime. This seems unfortunate, since the only purpose of this
method is to generate `authToken`, can we just do it in `CSIServer::create` in which way we
can error out earlier when agent is just started. And then I think we do not need this method
`CSIServerProcess::start()` at all, we can just keep the method `CSIServer::start()` where
we can just do `started.set(Nothing());`. WDYT?

I'm now handling any errors from `CSIServer::start()` in the agent code, where we will exit
in the case of failure. Take a look and let me know if there are any issues: https://reviews.apache.org/r/72761/diff/4#index_header


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221599
-----------------------------------------------------------


On Aug. 19, 2020, 6:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2020, 6:23 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the CSI server to attempt to
> initialize unknown plugins when it receives publish
> or unpublish calls meant for plugins that it does
> not recognize.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 
>   src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message