mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Tue, 18 Aug 2020 06:44:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221617
-----------------------------------------------------------



Bad review!

Reviews applied: [72779, 72728, 72761, 72727, 72726, 72754, 72753, 72734, 72733, 72690, 72716,
72732]

Error:
2020-08-18 06:44:21 URL:https://reviews.apache.org/r/72779/diff/raw/ [9841/9841] -> "72779.patch"
[1]
error: patch failed: src/slave/csi_server.cpp:236
error: src/slave/csi_server.cpp: patch does not apply

- Mesos Reviewbot


On Aug. 15, 2020, 11:54 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2020, 11:54 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the CSI server to lazily initialize CSI
> plugins on-demand when the server receives publish or
> unpublish calls for a plugin which is not already
> successfully initialized.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message