mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.
Date Tue, 18 Aug 2020 04:57:41 GMT


> On Aug. 13, 2020, 10:21 p.m., Greg Mann wrote:
> > src/csi/service_manager.cpp
> > Lines 740 (patched)
> > <https://reviews.apache.org/r/72759/diff/1/?file=2237900#file2237900line740>
> >
> >     Where does this env var name come from, 'MESOS_NODE_ID'?
> 
> Qian Zhang wrote:
>     Orginially I wanted to just name it `NODE_ID`, however I think it is too generic
and may be conflict with other env var used by the CSI plugin. So I changed to add a `MESOS_`
prefix just like other env vars that Mesos sets for containers, e.g. `MESOS_FRAMEWORK_ID`,
`MESOS_SLAVE_ID`, `MESOS_AGENT_ENDPOINT`. Or maybe we should name it `MESOS_AGENT_IP`?

Hm, I think this may not yield a good ID for the agent, since I think it's possible that the
value of `self().address.ip` could be the same across all nodes in the cluster - I think it
could be `0.0.0.0`/`INADDR_ANY`, for example. Do you think we need to inject the Mesos agent
ID into the service manager so that we can use it as the node ID here?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72759/#review221574
-----------------------------------------------------------


On Aug. 12, 2020, 11:47 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72759/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2020, 11:47 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10175
>     https://issues.apache.org/jira/browse/MESOS-10175
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved CSI service manager to set node ID for managed CSI plugins.
> 
> 
> Diffs
> -----
> 
>   src/csi/service_manager.cpp 7a8d8e5dc3c3bae5251284652d73b33ca554f783 
> 
> 
> Diff: https://reviews.apache.org/r/72759/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message