mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.
Date Mon, 17 Aug 2020 21:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72738/#review221606
-----------------------------------------------------------




include/mesos/scheduler/scheduler.proto
Lines 261-264 (patched)
<https://reviews.apache.org/r/72738/#comment310668>

    Thanks for documenting the subtlety here! Perhaps say that we do not advise using multiple
attributes with the same name. (maybe also a TODO that if it becomes a problem we could add
a `lookup_mode`, but oy.. I would try really hard to avoid that).


- Benjamin Mahler


On Aug. 14, 2020, 4:36 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72738/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2020, 4:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10171
>     https://issues.apache.org/jira/browse/MESOS-10171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds framework's offer constraints  into `Subscribe` and
> `UpdateFramework` calls, which is a prerequisite to implementing
> constraints-based offer filtering (see MESOS-10161).
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc 
>   include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3

>   src/internal/devolve.cpp 4527c522473b74622055e1765740e3706b95afdb 
> 
> 
> Diff: https://reviews.apache.org/r/72738/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message