mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Date Mon, 17 Aug 2020 07:15:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221599
-----------------------------------------------------------




src/slave/csi_server.cpp
Line 225 (original), 212 (patched)
<https://reviews.apache.org/r/72779/#comment310664>

    What if this method fails somewhere and returns a `Failure`? As the result `CSIServer::started.future()`
will be a failed future and then all the `CSIServer::publishVolume` and `CSIServer::unpublishVolume`
calls will just fail in the runtime. This seems unfortunate, since the only purpose of this
method is to generate `authToken`, can we just do it in `CSIServer::create` in which way we
can error out earlier when agent is just started. And then I think we do not need this method
`CSIServerProcess::start()` at all, we can just keep the method `CSIServer::start()` where
we can just do `started.set(Nothing());`. WDYT?


- Qian Zhang


On Aug. 15, 2020, 11:54 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72779/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2020, 11:54 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the CSI server to lazily initialize CSI
> plugins on-demand when the server receives publish or
> unpublish calls for a plugin which is not already
> successfully initialized.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222 
> 
> 
> Diff: https://reviews.apache.org/r/72779/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message