mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72728: Added a unit test for the CSI server.
Date Sat, 15 Aug 2020 13:59:17 GMT


> On Aug. 12, 2020, 3:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 96 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line96>
> >
> >     Why do we need this parameter?

Yea I can get rid of this, thanks!


> On Aug. 12, 2020, 3:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 114-121 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line114>
> >
> >     It seems the required flag [--endpoint](https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132)
is not set here?
> 
> Qian Zhang wrote:
>     Sorry, the link to the `--endpoint` should be https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132

I had to look through the code; it turns out the service manager injects the endpoint flag
for managed plugins: https://github.com/apache/mesos/blob/831f172de7908ad8e40d14905cacb3a9c053e832/src/csi/service_manager.cpp#L713-L727

Maybe I should add a comment here mentioning that the flag is injected elsewhere?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221553
-----------------------------------------------------------


On Aug. 13, 2020, 6:38 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2020, 6:38 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353 
>   src/tests/csi_server_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/4/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message