mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.
Date Fri, 14 Aug 2020 17:38:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72741/
-----------------------------------------------------------

(Updated Aug. 14, 2020, 5:38 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Added a comment explaining how this code relies on `oneof` contract.


Bugs: MESOS-10171
    https://issues.apache.org/jira/browse/MESOS-10171


Repository: mesos


Description
-------

This patch implements an offer filtering object that supports the
Exists/NotExists offer constraints, and adds it into the allocator
interface.

More constraints will be added to this filter in further patches.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 
  src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea 
  src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 
  src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION 
  src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb 


Diff: https://reviews.apache.org/r/72741/diff/3/

Changes: https://reviews.apache.org/r/72741/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message