mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.
Date Fri, 14 Aug 2020 02:27:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72754/#review221579
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/containerizer.cpp
Lines 224 (patched)
<https://reviews.apache.org/r/72754/#comment310649>

    Need include for 'slave/csi_server.hpp'.



src/slave/containerizer/mesos/containerizer.cpp
Lines 185 (patched)
<https://reviews.apache.org/r/72754/#comment310648>

    Need include for 'slave/csi_server.hpp'.


- Greg Mann


On Aug. 13, 2020, 6:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72754/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2020, 6:14 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10156
>     https://issues.apache.org/jira/browse/MESOS-10156
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled the `volume/csi` isolator in `MesosContainerizer`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp 2b3c4c0363a6362c62695f087ea25248657d99df

>   src/slave/containerizer/containerizer.cpp 9e44e5e0a41e48121f147778295a07b10b03bcf2

>   src/slave/containerizer/mesos/containerizer.hpp 56e4c49733ac4e236b81ebf9e3238bf8a189c9f2

>   src/slave/containerizer/mesos/containerizer.cpp 3c1840cae4befe09581ea4efae855d552bd19b05

> 
> 
> Diff: https://reviews.apache.org/r/72754/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message