mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.
Date Fri, 14 Aug 2020 01:12:06 GMT


> On Aug. 14, 2020, 6:21 a.m., Greg Mann wrote:
> > src/csi/service_manager.cpp
> > Lines 740 (patched)
> > <https://reviews.apache.org/r/72759/diff/1/?file=2237900#file2237900line740>
> >
> >     Where does this env var name come from, 'MESOS_NODE_ID'?

Orginially I wanted to just name it `NODE_ID`, however I think it is too generic and may be
conflict with other env var used by the CSI plugin. So I changed to add a `MESOS_` prefix
just like other env vars that Mesos sets for containers, e.g. `MESOS_FRAMEWORK_ID`, `MESOS_SLAVE_ID`,
`MESOS_AGENT_ENDPOINT`. Or maybe we should name it `MESOS_AGENT_IP`?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72759/#review221574
-----------------------------------------------------------


On Aug. 12, 2020, 7:47 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72759/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2020, 7:47 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10175
>     https://issues.apache.org/jira/browse/MESOS-10175
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved CSI service manager to set node ID for managed CSI plugins.
> 
> 
> Diffs
> -----
> 
>   src/csi/service_manager.cpp 7a8d8e5dc3c3bae5251284652d73b33ca554f783 
> 
> 
> Diff: https://reviews.apache.org/r/72759/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message