-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72761/#review221560
-----------------------------------------------------------
src/slave/main.cpp
Lines 577 (patched)
<https://reviews.apache.org/r/72761/#comment310626>
This seems not correct to me, `process::network::inet4::Address::ANY_ANY().ip` is something
like `0.0.0.0`, right?
I think here we should use the actual IP the agent listens on, I see we set the env var
`LIBPROCESS_IP` at line 336, maybe we should use that as the agent IP here? And if `os::getenv("LIBPROCESS_IP")`
returns `None` then we should use `process::network::inet4::Address::LOOPBACK_ANY().ip`.
Ditto for the same code in `src/tests/cluster.cpp`.
src/slave/slave.hpp
Lines 892 (patched)
<https://reviews.apache.org/r/72761/#comment310627>
Why does slave need CSI server as its member?
src/tests/cluster.hpp
Lines 59 (patched)
<https://reviews.apache.org/r/72761/#comment310628>
This line should be put below the line `#include "slave/constants.hpp"`.
- Qian Zhang
On Aug. 13, 2020, 3:19 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72761/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2020, 3:19 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a CSI server to the Mesos agent in both
> the agent binary and in tests.
>
>
> Diffs
> -----
>
> src/local/local.cpp 895057027165609c792089cd336988b65a3b305d
> src/slave/main.cpp 0aa2cc9d254d0b74485a0584b9f55c2266f29367
> src/slave/slave.hpp 2cf45c616d5c50508bc5cd77096b0fef86542b1d
> src/slave/slave.cpp c828d99ca9909b904767cc9ea5671b462714f547
> src/tests/cluster.hpp 415a60f5fd4881bca329ffd718f58d676653a17d
> src/tests/cluster.cpp ab4cea49eb3e8cf18d320fbb30beaa3c454a08b0
> src/tests/mesos.hpp 0ad0999fba185539c90b053bda43be001da26253
> src/tests/mesos.cpp d6933a60c55802e6f9e89242608fbfad7631faed
> src/tests/mock_slave.hpp 58daefa4459eaf15c2394f14db9f94527984b2b8
> src/tests/mock_slave.cpp fa2a0f5c8dadeb8aea87815741bc4fe071d5fbe0
>
>
> Diff: https://reviews.apache.org/r/72761/diff/1/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
|