-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221553
-----------------------------------------------------------
src/tests/csi_server_tests.cpp
Lines 96 (patched)
<https://reviews.apache.org/r/72728/#comment310621>
Why do we need this parameter?
src/tests/csi_server_tests.cpp
Lines 114-121 (patched)
<https://reviews.apache.org/r/72728/#comment310620>
It seems the required flag [--endpoint](https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132)
is not set here?
- Qian Zhang
On Aug. 11, 2020, 11:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 11:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
|