mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.
Date Wed, 12 Aug 2020 03:17:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72727/#review221554
-----------------------------------------------------------




src/examples/test_csi_plugin.cpp
Lines 174-177 (patched)
<https://reviews.apache.org/r/72727/#comment310622>

    Why do we need this flag? Without this flag, would the unit test in https://reviews.apache.org/r/72728
be affected?



src/examples/test_csi_plugin.cpp
Line 1590 (original), 1614 (patched)
<https://reviews.apache.org/r/72727/#comment310623>

    I think this will break the case when `--volume_id_path` is set to true, in which case
`volumeInfo.id` is already set to `getVolumePath(capacity, name)` in the constructor and now
here we call `getVolumePath` again which will give us a wrong volume path.


- Qian Zhang


On Aug. 12, 2020, 2:55 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72727/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2020, 2:55 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds additional configuration flags to the
> test CSI plugin which are necessary in order to test
> the agent's CSI server.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_plugin.cpp 214a3ee4481512b025ff054db6ffe15d476b0264 
> 
> 
> Diff: https://reviews.apache.org/r/72727/diff/3/
> 
> 
> Testing
> -------
> 
> These new flags are used in a subsequent test in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message