mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72732: Added support for secrets to the CSI volume managers.
Date Tue, 11 Aug 2020 04:21:09 GMT


> On Aug. 10, 2020, 9:07 a.m., Qian Zhang wrote:
> > src/csi/v0_volume_manager_process.hpp
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/72732/diff/3/?file=2237445#file2237445line186>
> >
> >     I do not see how this secret resolver is used in v0 volume manager.

:facepalm:


> On Aug. 10, 2020, 9:07 a.m., Qian Zhang wrote:
> > src/csi/v1_volume_manager.cpp
> > Lines 1316 (patched)
> > <https://reviews.apache.org/r/72732/diff/3/?file=2237447#file2237447line1316>
> >
> >     Is it possible for `secretResolver` to be null?

Yep; I updated the patch to handle that case.


> On Aug. 10, 2020, 9:07 a.m., Qian Zhang wrote:
> > src/csi/volume_manager.hpp
> > Lines 68 (patched)
> > <https://reviews.apache.org/r/72732/diff/3/?file=2237449#file2237449line68>
> >
> >     I see in https://reviews.apache.org/r/72716 (csi_server.cpp#L223), you already
passed `secretResolver` as a parameter of `VolumeManager::create`, so I think this patch should
be moved before that patch in the chain, otherwise that patch cannot compile:
> >     ```
> >     ../../../src/slave/csi_server.cpp: In lambda function:
> >     ../../../src/slave/csi_server.cpp:231:27: error: no matching function for call
to 'mesos::csi::VolumeManager::create(const string&, const mesos::CSIPluginInfo&,
hashset<mesos::CSIPluginContainerInfo_Service>, const string&, process::grpc::client::Runtime&,
mesos::csi::ServiceManager*, mesos::csi::Metrics*, mesos::SecretResolver*&)'
> >                  secretResolver);
> >                                ^
> >     In file included from ../../../src/slave/csi_server.cpp:47:0:
> >     ../../../src/csi/volume_manager.hpp:58:45: note: candidate: static Try<process::Owned<mesos::csi::VolumeManager>
> mesos::csi::VolumeManager::create(const string&, const mesos::CSIPluginInfo&,
const hashset<mesos::CSIPluginContainerInfo_Service>&, const string&, const
process::grpc::client::Runtime&, mesos::csi::ServiceManager*, mesos::csi::Metrics*)
> >        static Try<process::Owned<VolumeManager>> create(
> >                                                  ^
> >     ../../../src/csi/volume_manager.hpp:58:45: note:   candidate expects 7 arguments,
8 provided
> >     ```

I updated the chain; this patch now sits at the beginning. Thanks!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72732/#review221520
-----------------------------------------------------------


On Aug. 11, 2020, 4:20 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72732/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2020, 4:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10168
>     https://issues.apache.org/jira/browse/MESOS-10168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for secrets to the CSI volume managers.
> 
> 
> Diffs
> -----
> 
>   src/csi/state.proto 836e30c74026ef87896cbb537b14a3b97445bea1 
>   src/csi/v0_volume_manager.hpp 93183c2b0187ceb41533c7e022f2a5ef1f23d9a1 
>   src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423 
>   src/csi/v0_volume_manager_process.hpp 7548c43aa982759296f1413866f14b5280404185 
>   src/csi/v1_volume_manager.hpp 2f7897d416895f4be0efd32bdce90df9049bdf58 
>   src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56 
>   src/csi/v1_volume_manager_process.hpp b8a1ef7d58438633e497f86ff6604664d3a80b8c 
>   src/csi/volume_manager.hpp 57e7c51d0baf296ce5ceb0385a7da0776b3545aa 
>   src/csi/volume_manager.cpp c47adfe426419cf71dc1f2cb435aa241904ed8a2 
> 
> 
> Diff: https://reviews.apache.org/r/72732/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message