mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72728: Added a unit test for the CSI server.
Date Mon, 10 Aug 2020 08:10:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221523
-----------------------------------------------------------




src/Makefile.am
Lines 2831 (patched)
<https://reviews.apache.org/r/72728/#comment310571>

    It seems we need 3 more tabs between `csi_server_tests.cpp` and ``.



src/tests/csi_server_tests.cpp
Lines 22-23 (patched)
<https://reviews.apache.org/r/72728/#comment310572>

    These two lines should be put above the line `#include <mesos/master/detector.hpp>`.



src/tests/csi_server_tests.cpp
Lines 92 (patched)
<https://reviews.apache.org/r/72728/#comment310573>

    I do not see how `slaveWorkDirs` is used afterward.


- Qian Zhang


On Aug. 7, 2020, 3:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2020, 3:02 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 
>   src/tests/csi_server_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72728/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message