mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72716: Added implementation of the CSI server.
Date Fri, 07 Aug 2020 12:01:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72716/#review221499
-----------------------------------------------------------




src/slave/csi_server.cpp
Lines 99-103 (patched)
<https://reviews.apache.org/r/72716/#comment310534>

    I think usually we define the static functions outside of the class, like:
    https://github.com/apache/mesos/blob/1.10.0/src/slave/slave.cpp#L180:L193
    https://github.com/apache/mesos/blob/1.10.0/src/master/master.cpp#L156



src/slave/csi_server.cpp
Lines 200 (patched)
<https://reviews.apache.org/r/72716/#comment310535>

    Do we need to include `info.type()` in the container prefix? Otherwise the container prefix
for all the managed CSI plugins will be same which may not be good for debugging.



src/slave/csi_server.cpp
Lines 272 (patched)
<https://reviews.apache.org/r/72716/#comment310536>

    If `info.target_path_root` is set, we should use it instead of `rootDir`.



src/slave/csi_server.cpp
Lines 336 (patched)
<https://reviews.apache.org/r/72716/#comment310537>

    Do we need to check if `volume/csi` isolator is enabled? Like:
    ```
    if (!strings::contains(flags.isolation, "volume/csi")) {
      return Error("...");
    }
    ```
    
    I think to make the whole CSI volume feature work, both `CSIServer` and `volume/csi` isolator
need to be enabled.
    
    And in which condition will we call `CSIServer::create` to create `CSISever`? When `--csi_plugin_config_dir`
is specified? If so, I think here we need a `CHECK` rather than an `if`.



src/slave/csi_server.cpp
Lines 413-415 (patched)
<https://reviews.apache.org/r/72716/#comment310538>

    Do we need to define `started` as a promise here? Can we just define it as a future?
    ```
    started = process::dispatch(process.get(), &CSIServerProcess::start);
    return started;
    ```


- Qian Zhang


On Aug. 7, 2020, 3 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72716/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2020, 3 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation of the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea 
>   src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 
>   src/slave/csi_server.hpp 17882e1be5a6c38ca34d7b50d4a6041530e8908c 
>   src/slave/csi_server.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72716/diff/5/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message