mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 72739: Introduced a `FrameworkOptions` struct into the allocator interface.
Date Thu, 06 Aug 2020 16:32:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72739/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10171
    https://issues.apache.org/jira/browse/MESOS-10171


Repository: mesos


Description
-------

This patch supersedes the `suppressedRoles` parameter of the
`addFramework()`/`updateFramework()` allocator methods with a more
general `FrameworkOptions` struct that will allow to add more
allocation options that are of no interest to agents (and thus are
not included into the `FrameworkInfo` protobuf).


Diffs
-----

  include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 
  src/master/allocator/mesos/allocator.hpp dd7952b55958a3f323b9ab103db846b85db79f36 
  src/master/allocator/mesos/hierarchical.hpp e444e470eb085cea167f84f8540d1769d662c222 
  src/master/allocator/mesos/hierarchical.cpp 9e5079942263132d09c6bd9abbdc8858cd2ef138 
  src/master/master.hpp 214307fcae47905672260758a1b96a034ed80257 
  src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb 
  src/tests/allocator.hpp 476560427a50e3f7d21d170f1d3a72290328852a 
  src/tests/master_allocator_tests.cpp d2580c34452829eb8ae04e81c2dbbe6a13dde40e 
  src/tests/reservation_tests.cpp cd84cd24d3587fafc01ae1861f22c47262f2d7e9 
  src/tests/resource_offers_tests.cpp 08bb10957007a8af583157f5db365bd59a39c814 
  src/tests/slave_recovery_tests.cpp da163a2e06ccde6ea05bf6717bea184e81844a4d 


Diff: https://reviews.apache.org/r/72739/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message