mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.
Date Tue, 04 Aug 2020 22:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72690/#review221468
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp
Lines 20-25 (patched)
<https://reviews.apache.org/r/72690/#comment310479>

    Also need includes for `Future`, `Option`, `Nothing`, `Try`, `vector`, `string`, Mesos
protos, `hashset`, `ProcessBase`, and `ContainerState`



src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Lines 17-22 (patched)
<https://reviews.apache.org/r/72690/#comment310480>

    Missing includes for types used in this file like `string`, `Future`, etc.



src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Lines 41 (patched)
<https://reviews.apache.org/r/72690/#comment310481>

    Should we do a check for `if (csiServer == nullptr)` in the body of `create()`?


- Greg Mann


On Aug. 4, 2020, 8:18 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72690/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2020, 8:18 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10152
>     https://issues.apache.org/jira/browse/MESOS-10152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the framework and `create` method of `volume/csi` isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea 
>   src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72690/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message