mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72732: Added support for secrets to the CSI server and volume manager.
Date Tue, 04 Aug 2020 20:28:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72732/#review221467
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72660, 72661, 72672, 72681, 72715, 72707, 72716, 72726, 72727, 72728, 72732]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Aug. 4, 2020, 5:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72732/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2020, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10168
>     https://issues.apache.org/jira/browse/MESOS-10168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for secrets to the CSI server and volume manager.
> 
> 
> Diffs
> -----
> 
>   src/csi/state.proto 836e30c74026ef87896cbb537b14a3b97445bea1 
>   src/csi/v0_volume_manager.hpp 93183c2b0187ceb41533c7e022f2a5ef1f23d9a1 
>   src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423 
>   src/csi/v0_volume_manager_process.hpp 7548c43aa982759296f1413866f14b5280404185 
>   src/csi/v1_volume_manager.hpp 2f7897d416895f4be0efd32bdce90df9049bdf58 
>   src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56 
>   src/csi/v1_volume_manager_process.hpp b8a1ef7d58438633e497f86ff6604664d3a80b8c 
>   src/csi/volume_manager.hpp 57e7c51d0baf296ce5ceb0385a7da0776b3545aa 
>   src/csi/volume_manager.cpp c47adfe426419cf71dc1f2cb435aa241904ed8a2 
>   src/slave/csi_server.hpp 17882e1be5a6c38ca34d7b50d4a6041530e8908c 
>   src/slave/csi_server.cpp PRE-CREATION 
>   src/tests/csi_server_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72732/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message