> On Aug. 3, 2020, 1:16 a.m., Qian Zhang wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 645-651 (original), 645-651 (patched)
> > <https://reviews.apache.org/r/72726/diff/1/?file=2236763#file2236763line645>
> >
> > I am a bit confused about the purpose of this code. This is a `foreach` loop
for `services`, but in each iteration of the loop we always use the **first service** (i.e.
`*services.begin()`) or the **CONTROLLER_SERVICE** (the old code) to make the `getPluginInfo`
call. And in the code below, we compare the result of each call, but I think they must be
consistent since we make the exactly same call in each iteration, right?
> >
> > So I guess we should make the `getPluginInfo` call with the `service` variable
as the first parameter, right?
Whoops sorry!!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72726/#review221449
-----------------------------------------------------------
On Aug. 3, 2020, 7:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72726/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2020, 7:05 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the volume managers would assume that they could
> make CONTROLLER_SERVICE calls during plugin initialization,
> regardless of whether or not the plugin provides that service.
>
>
> Diffs
> -----
>
> src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423
> src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56
>
>
> Diff: https://reviews.apache.org/r/72726/diff/2/
>
>
> Testing
> -------
>
> This change is necessary for a subsequent test later in this chain to pass.
>
>
> Thanks,
>
> Greg Mann
>
>
|