-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72716/#review221447
-----------------------------------------------------------
src/slave/csi_server.cpp
Lines 114-115 (patched)
<https://reviews.apache.org/r/72716/#comment310459>
Based on your code below, I think the key of the this map should be plugin name rather
than plugin type.
src/slave/csi_server.cpp
Lines 145-148 (patched)
<https://reviews.apache.org/r/72716/#comment310460>
I think here we need to handle two cases:
1. Managed CSI plugin as what you have done here.
2. Unmanaged CSI plugin: We need to get its services from `plugin.endpoints.csi_service`.
src/slave/csi_server.cpp
Lines 223-231 (patched)
<https://reviews.apache.org/r/72716/#comment310461>
I need to instantiate service manager differently based on that it is a managed plugin
or unmanaged plugin. For unmanaged plugin we should call the new constructor of service manager
introduced in https://reviews.apache.org/r/72683/ .
- Qian Zhang
On Aug. 1, 2020, 3 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72716/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2020, 3 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added implementation of the CSI server.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/slave/csi_server.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72716/diff/3/
>
>
> Testing
> -------
>
> Details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
|