From reviews-return-92048-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 21 20:29:54 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 0BEB919D6C for ; Tue, 21 Jul 2020 20:29:54 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 73E51124E3F for ; Tue, 21 Jul 2020 20:29:53 +0000 (UTC) Received: (qmail 51428 invoked by uid 500); 21 Jul 2020 20:29:53 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51407 invoked by uid 500); 21 Jul 2020 20:29:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51385 invoked by uid 99); 21 Jul 2020 20:29:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2020 20:29:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6333FC0385 for ; Tue, 21 Jul 2020 20:29:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.714 X-Spam-Level: * X-Spam-Status: No, score=1.714 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.251, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Wadl4tx0tb0P for ; Tue, 21 Jul 2020 20:29:48 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 4F0C47F5E1 for ; Tue, 21 Jul 2020 20:29:48 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 18E49160F10; Tue, 21 Jul 2020 20:29:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5867744262492748845==" MIME-Version: 1.0 Subject: Re: Review Request 72681: Enabled pre-provisioned volumes in the volume manager. From: Mesos Reviewbot To: Qian Zhang , Andrei Budnik Cc: Mesos Reviewbot , Greg Mann , mesos Date: Tue, 21 Jul 2020 20:29:46 -0000 Message-ID: <20200721202946.20915.30310@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72681/ X-Sender: Mesos Reviewbot References: <20200721164704.17393.16194@reviews-vm-he-fi.apache.org> In-Reply-To: <20200721164704.17393.16194@reviews-vm-he-fi.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============5867744262492748845== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72681/#review221294 ----------------------------------------------------------- Patch looks great! Reviews applied: [72681] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On July 21, 2020, 4:47 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72681/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 4:47 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10150 > https://issues.apache.org/jira/browse/MESOS-10150 > > > Repository: mesos > > > Description > ------- > > This patch makes it possible to publish CSI volumes on an > agent which were pre-provisioned out of band. > > > Diffs > ----- > > src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470 > src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234 > src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736 > src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0 > src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654 > src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47 > src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478 > src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357 > > > Diff: https://reviews.apache.org/r/72681/diff/3/ > > > Testing > ------- > > > Thanks, > > Greg Mann > > --===============5867744262492748845==--