From reviews-return-92047-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 21 18:43:40 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 201E6198F7 for ; Tue, 21 Jul 2020 18:43:40 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 7A603123985 for ; Tue, 21 Jul 2020 18:43:39 +0000 (UTC) Received: (qmail 32631 invoked by uid 500); 21 Jul 2020 18:43:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32619 invoked by uid 500); 21 Jul 2020 18:43:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32602 invoked by uid 99); 21 Jul 2020 18:43:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2020 18:43:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3307B1A3491 for ; Tue, 21 Jul 2020 18:43:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.715 X-Spam-Level: * X-Spam-Status: No, score=1.715 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.251, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3xgt-59SZraZ for ; Tue, 21 Jul 2020 18:43:36 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 758CABB947 for ; Tue, 21 Jul 2020 18:43:36 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 36CD0160F10; Tue, 21 Jul 2020 18:43:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7193744399002260354==" MIME-Version: 1.0 Subject: Re: Review Request 72660: Added CSI volume type into the `Volume` protobuf message. From: Greg Mann To: Andrei Budnik , Greg Mann Cc: Qian Zhang , mesos Date: Tue, 21 Jul 2020 18:43:34 -0000 Message-ID: <20200721184334.17393.30668@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20200721030936.21172.11502@reviews-vm-he-fi.apache.org> X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72660/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20200721030936.21172.11502@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: include/mesos/csi/types.hpp X-ReviewBoard-Diff-For: src/csi/types.cpp X-ReviewBoard-Diff-For: include/mesos/csi/types.proto X-ReviewBoard-ShipIt-Only: 1 Reply-To: Greg Mann X-ReviewRequest-Repository: mesos Sender: Greg Mann --===============7193744399002260354== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72660/#review221292 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On July 21, 2020, 3:09 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72660/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 3:09 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10147 > https://issues.apache.org/jira/browse/MESOS-10147 > > > Repository: mesos > > > Description > ------- > > Also removed the `types.proto` file which has `VolumeCapability` > defined as well so that we will have a single place (`mesos.proto`) > to define this protobuf message. > > > Diffs > ----- > > include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d > include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c > include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129 > include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff > include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2 > include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5 > src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792 > src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 > src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05 > src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470 > src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8 > src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3 > src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2 > src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234 > src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736 > src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0 > src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc > src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544 > src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654 > src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47 > src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478 > src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357 > src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2 > src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182 > src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf > src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0 > > > Diff: https://reviews.apache.org/r/72660/diff/6/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============7193744399002260354==--