mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72707: Added interface for the CSI server.
Date Mon, 27 Jul 2020 08:06:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72707/#review221375
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/csi_server.hpp
Line 42 (original), 48 (patched)
<https://reviews.apache.org/r/72707/#comment310302>

    I think we do not need `slave::` here. And it's better to name this parameter `_flags`
to be consistent withe the other two parameters.



src/slave/csi_server.hpp
Line 59 (original), 66-67 (patched)
<https://reviews.apache.org/r/72707/#comment310305>

    I think we need to return `std::string` by `publishVolume` rather than `unpublishVolume`.
    
    And do we need the whole `CSIVolume` as the parameter? I think we only need plugin name
and volume ID, right?


- Qian Zhang


On July 27, 2020, 1:37 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72707/
> -----------------------------------------------------------
> 
> (Updated July 27, 2020, 1:37 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added interface for the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72707/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message