mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72707: Added interface for the CSI server.
Date Mon, 27 Jul 2020 05:38:39 GMT


> On July 24, 2020, 8:50 a.m., Qian Zhang wrote:
> > src/CMakeLists.txt
> > Lines 165 (patched)
> > <https://reviews.apache.org/r/72707/diff/2/?file=2236256#file2236256line165>
> >
> >     I think we should put this line to L153 under `slave/container_logger.cpp`.

Agreed. I just removed everything from this patch but the header for now; I have a patch in
progress with the full implementation, will post soon.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72707/#review221352
-----------------------------------------------------------


On July 27, 2020, 5:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72707/
> -----------------------------------------------------------
> 
> (Updated July 27, 2020, 5:37 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added interface for the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/slave/csi_server.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72707/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message