mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72707: Added interface for the CSI server.
Date Fri, 24 Jul 2020 08:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72707/#review221352
-----------------------------------------------------------




src/CMakeLists.txt
Lines 165 (patched)
<https://reviews.apache.org/r/72707/#comment310244>

    I think we should put this line to L153 under `slave/container_logger.cpp`.



src/Makefile.am
Lines 1326-1327 (patched)
<https://reviews.apache.org/r/72707/#comment310245>

    Ditto.



src/slave/csi_server.hpp
Lines 41-43 (patched)
<https://reviews.apache.org/r/72707/#comment310247>

    Instead of `configDir`, I think we need agent `Flags` and in this `create` method we need
to scan the directory `--csi_plugin_config_dir` to load the supported CSI plugin configs.
    
    And I think we also need secret generator to generate auth token for service manager to
use, see:
    https://github.com/apache/mesos/blob/1.10.0/src/resource_provider/daemon.cpp#L543
    https://github.com/apache/mesos/blob/1.10.0/src/resource_provider/storage/provider.cpp#L575



src/slave/csi_server.hpp
Lines 52 (patched)
<https://reviews.apache.org/r/72707/#comment310251>

    I think we may need this method to return the target path at which the volume is published,
and then in `volume/csi` we can bind mount that path into the container's mount namespace
for container to use.


- Qian Zhang


On July 24, 2020, 2 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72707/
> -----------------------------------------------------------
> 
> (Updated July 24, 2020, 2 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10163
>     https://issues.apache.org/jira/browse/MESOS-10163
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added interface for the CSI server.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792 
>   src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 
>   src/slave/csi_server.hpp PRE-CREATION 
>   src/slave/csi_server.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72707/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message