mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Date Wed, 22 Jul 2020 06:27:03 GMT


> On July 17, 2020, 7:22 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 1106 (original), 1106 (patched)
> > <https://reviews.apache.org/r/72661/diff/5/?file=2235882#file2235882line1106>
> >
> >     I'm not sure that we should mark this as deprecated, since it's still useful
for the LVM driver?
> 
> Qian Zhang wrote:
>     Yeah, it is still userful for the LVM driver, but will we continue to support it
in long term?
> 
> Greg Mann wrote:
>     I would propose that we don't tie this patch to the decision of whether or not we
want to continue supporting it, I'm not sure what the answer for that is?

Agree, let me remove `deprecated=true`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------


On July 22, 2020, 2:26 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
> 
> (Updated July 22, 2020, 2:26 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10148
>     https://issues.apache.org/jira/browse/MESOS-10148
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129 
>   include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5 
> 
> 
> Diff: https://reviews.apache.org/r/72661/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message