mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72681: Enabled pre-provisioned volumes in the volume manager.
Date Mon, 20 Jul 2020 03:21:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72681/#review221262
-----------------------------------------------------------




src/csi/v0_volume_manager.hpp
Lines 103 (patched)
<https://reviews.apache.org/r/72681/#comment310134>

    s/volumeState/volumeState = None()/
    
    Ditto for v1 volume manager.



src/csi/v0_volume_manager.cpp
Lines 460-462 (patched)
<https://reviews.apache.org/r/72681/#comment310136>

    `CHECK` seems too much to me, is it OK to abort agent in this case? I think returning
a failure should be enough.
    
    Ditto for v1 volume manager.



src/csi/v0_volume_manager.cpp
Lines 1346 (patched)
<https://reviews.apache.org/r/72681/#comment310137>

    I think we should have each parameter in its own line rather than all in the single line.
    
    Ditto for v1 volume manager.



src/csi/volume_manager.hpp
Line 135 (original), 145 (patched)
<https://reviews.apache.org/r/72681/#comment310138>

    I think we also need to update the comments here, like: for untracked volumes, it will
be removed actually.


- Qian Zhang


On July 18, 2020, 6:38 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72681/
> -----------------------------------------------------------
> 
> (Updated July 18, 2020, 6:38 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10150
>     https://issues.apache.org/jira/browse/MESOS-10150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes it possible to publish CSI volumes on an
> agent which were pre-provisioned out of band.
> 
> 
> Diffs
> -----
> 
>   src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470 
>   src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234 
>   src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736 
>   src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0 
>   src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654 
>   src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47 
>   src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478 
>   src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357 
> 
> 
> Diff: https://reviews.apache.org/r/72681/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message